Skip to content

HIVE-29237: Addendum: Hive: Refactor commit lock mechanism from HiveTableOperations (#6648) #6112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

HIVE-29237: Addendum: Hive: Refactor commit lock mechanism from HiveTableOperations (#6648) #6112

merged 1 commit into from
Oct 7, 2025

Conversation

InvisibleProgrammer
Copy link
Contributor

@InvisibleProgrammer InvisibleProgrammer commented Oct 3, 2025 •
edited
Loading

(cherry picked from commit 333227fbd13821365cec1bdbfcb9314a239bea0f)

Note: this is not a full port: it is about porting some missing changes from the previous port especially for test cases.

What changes were proposed in this pull request?

Add missing ports from Iceberg in TestHiveCommitLocks.

Why are the changes needed?

It lead to flakyness on downstream.

Does this PR introduce any user-facing change?

No

How was this patch tested?

deniskuzZ
deniskuzZ approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@deniskuzZ deniskuzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deniskuzZ
Copy link
Member

deniskuzZ commented Oct 6, 2025 •
edited
Loading

@InvisibleProgrammer since it's an addendum, I noticed that doUnlock was moved to MetastoreLock but wasn't removed from HiveTableOperations and is a dead code now.

void doUnlock(HiveLock lock) {
    if (lock != null) {
      try {
        lock.unlock();
      } catch (Exception e) {
        LOG.warn("Failed to unlock {}.{}", database, tableName, e);
      }
    }
  }

@deniskuzZ
Copy link
Member

could you please update the commit message, explicitly mentioning that we only port the test fixes, not the production code

@pvary @szlta @InvisibleProgrammer
HIVE-29237: Addendum: Hive: Refactor commit lock mechanism from HiveT…
5015d2d 
…ableOperations (#6648)

Note: this is not a full port: it is about porting some missing changes from the previous port especially for test cases.

Co-authored-by: Adam Szita <[email protected]>
Co-authored-by: Peter Vary <[email protected]>
(cherry picked from commit 333227fbd13821365cec1bdbfcb9314a239bea0f)
@InvisibleProgrammer
Copy link
Contributor Author

Both commit message and PR description modified.
doUnlock removed from HiveTableOperations.

@deniskuzZ
Copy link
Member

Both commit message and PR description modified. doUnlock removed from HiveTableOperations.

thanks @InvisibleProgrammer, i'll merge with the green build

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@deniskuzZ deniskuzZ merged commit b115c85 into apache:master Oct 7, 2025
4 checks passed
@InvisibleProgrammer InvisibleProgrammer deleted the HIVE-29237 branch October 7, 2025 08:50
@okumin okumin mentioned this pull request Oct 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deniskuzZ deniskuzZ deniskuzZ approved these changes

Assignees

No one assigned

Labels

tests passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@InvisibleProgrammer @deniskuzZ @asf-ci-hive @pvary